Dear Mike, dear Dan, On Wed, Nov 18, 2009 at 11:25:41AM +0700, Mike Hansen wrote: > I ran some tests with all of the category patches, and there are a few > issues that need to be cleaned up before merging. Most of them only > show up when doctesting with -long (the standard option when merging). > > 1) TestSuite(Z).run() in combinat/sf/jack.py takes too long and should > be disabled.
Done; will push shortly. > 2) TestSuite(s).run() in combinat/sf/orthotriang.py fails after about > 3 minutes with a RuntimeError on this line: return > self._codomain._from_dict(dict(self._t(self.fake_sym.term(partition))), > coerce = True) It has been running for a while without crash here. After discussion with Mike on IRC, we assume that the crash was caused by the doctest's timeout sending a kill which is catched by Symmetrica. > 3) The time for weyl_characters.py to complete on -long has gone up > to 250s or so. I'm not sure if this is due to adding more expensive > tests or a speed regression. This currently runs twice as long as > any other single file on -long. This is due to #5794, and the looooong tests for all the new cool exceptional types features. Dan: it is recommended for # long time tests to not exceed 30s (see http://www.sagemath.org/doc/developer/conventions.html). Would you have time shortly to go through the # long time tests, annotate them with about how much time they take and, if that exceeds 30s, replace the #long time by #not tested? Otherwise, let me know, and I'll take on the chore. Thanks! > 4) In root_system/weight_lattice_realization.py, I get 5 failures of > this type: "AttributeError: 'ClassicalWeylSubgroup' object has no > attribute '_list_from_iterator'" Fixed. I also removed the #long time, since they don't take more than 0.7s. Cheers, Nicolas -- Nicolas M. Thiéry "Isil" <nthi...@users.sf.net> http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-de...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=.
