Followups to sage-flame... In general all your objections are already dealt with by the deprecation framework, its just that in this exceptional / self-referential case it didn't work. Fine. I'm open for constructive suggestions, but you haven't given any. In the end, this patch is about making everyone's (including your own) work easier by enforcing consistency in the Sage library.
It took me more than 5h to write the patch. Also, my personal patch queue is now almost as long as sage-combinat so I'm very aware of the limitations. On Wednesday, August 1, 2012 4:35:02 PM UTC-4, Nicolas M. Thiery wrote: > > Dear Volker, > > On Mon, Jul 16, 2012 at 10:33:34AM -0700, Volker Braun wrote: > > I've rebased http://trac.sagemath.org/5457 on top of the deprecation > > change and it was a very easy change. > > Sure a very easy change. > > But this is to be multiplied by the number of patches. I for myself > wasted five straight hours on this. Others (Anne, Andrew, ...) did > spend quite some time too. Plus all the communication involved because > patches in the queue belong to 30+ people. Plus having the queue > partially broken for two weeks which certainly put off many newcomers > from the Sage days. > > All this energy would have been better off invested in getting > sage-combinat patches finished and merged. > > Yes, I take my share of responsibility: quite some of that would have > been saved if I could have put those 5 hours straight away; but I also > have the right to take vacations. > > Yes the fact that it takes soo much time is also due to our workflow > stretching the limits of mercurial queues. But at this point none of > the alternative workflows that have been proposed do satisfy our > constraints (see http://wiki.sagemath.org/combinat/CodeSharingWorkflow). > > All in all, in the future, I *will* put a negative review to similar > non essential global changes that impact much of "our" code (stuff in > combinat, ...). Unless the author volunteers to handle all the > rebasing work in the Sage-Combinat queue, together with the associated > communication. > > Best regards, > Nicolas > -- > Nicolas M. Thi�ry "Isil" <nthi...@users.sf.net> > http://Nicolas.Thiery.name/ > -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/6cEcP2f4rNgJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
