On Thu, Aug 23, 2012 at 07:16:44PM -0700, Andrew Mathas wrote:
> Could some one have a quick look a the patch #13259 at
> http://trac.sagemath.org/sage_trac/ticket/13259.
>
> It is a very short patch which correctly implements negative quantum
> integers, which were previously defined to be zero.
>
> arminstraub has reviewed the patch but I think he wanted some one else to
> check it as this was his "first attempt at reviewing a ticket".
Minor things:
- [n]_1 -> `[n]_1`
- ``p`` -> `p` ``q`` -> `q` ``n`` -> `n`
(for small input parameters like this it's fine writing them
directly as their math counterpart)
- `q`=1 -> `q=1`
- ``n!`` -> `n!`
Other than that, that sounds just fine. So once you have double
checked that the latex looks nice in the compiled documentation after
changing the above, you can set a positive review on my behalf.
Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" <nthi...@users.sf.net>
http://Nicolas.Thiery.name/
--
You received this message because you are subscribed to the Google Groups
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
To unsubscribe from this group, send email to
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sage-combinat-devel?hl=en.
