On 8/1/07, Martin Albrecht <[EMAIL PROTECTED]> wrote: > > Too late, I just did it, since I needed it for something else I'm > > doing (related to power series over polynomial rings). Martin, > > please have a look, since you might be able to improve the patch. > > I spot two things: > * The method does not preserve the term ordering (which might be tricky anyhow > because of block orderings and such). Wouldn't that be desired?
Yes, but it seemed tricky to implement. It would be desired. > * I think "cdef delete" is a very confusing choice for a function name, delete > is way too reserved to use it like that: "remove_from_tuple" maybe? Sure. > > PS: Obviously, this function could be faster but lets not optimize for the > sake of optimization. If anybody complaints we'll make it faster Agreed. When I did some benchmarks of it, it was already reasonably fast since it uses other things that have been optimized. --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/ -~----------~----~----~----~------~----~------~--~---
