On Monday 10 September 2007 18:21, Pablo De Napoli wrote:
> I could not read your modification to my patch since you've uploaded
> that as an hg bundle. I think that for trac the best would be to
> upload patches in plain text. That way, trac knows how to format it so
> that it can be easy read on the web
> (it would be nice to have something like trac but based on mercurial,
> rather than in subversion, but I doubt that such a program exists)
Yes, I did put it up as an hg bundle. I agree these are annoying, but they do
one thing nicely -- in that bundle are two patches which cleanly separates
the patch you wrote and the modifications I made to it. That separation is
not such a big deal here, but in general I think it is nice which is why I
did it this way. Of course, you can apply this to a vanilla 2.8.4.1 with 'hg
apply' (or whatever the hg_sage.<method> way is). For your own plain text
pleasure, my changes are attached.
I'd be interested to hear what other people have to say about proper trac
etiquette with bundles and patches building on one another.
--
Joel
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/
-~----------~----~----~----~------~----~------~--~---
# HG changeset patch
# User Joel B. Mohler <[EMAIL PROTECTED]>
# Date 1189455866 25200
# Node ID 6baf1b85853190a600968642018e79e560148ccf
# Parent 8def8d03e4a2edc4544cad18b931a706c2f8e0fe
Minor documentation changes for binomial global function on top of Pablo De Napoli's patch.
diff -r 8def8d03e4a2 -r 6baf1b858531 sage/rings/arith.py
--- a/sage/rings/arith.py Mon Sep 10 13:06:30 2007 -0700
+++ b/sage/rings/arith.py Mon Sep 10 13:24:26 2007 -0700
@@ -1858,21 +1858,19 @@ def binomial(x,m):
$$
x (x-1) \cdots (x-m+1) / m!
$$
- which is defined for $m \in \Z$ and any $x$.
- If $m<0$ return $0$.
-
- If x-m is an integer we define:
-
+ which is defined for $m \in \Z$ and any $x$. We extend this definition to
+ include cases when $x-m$ is an integer but $m$ is not by
+
binomial(x,m)= binomial(x,x-m)
- (This rule makes sense if x is assumed to be an integer)
-
+ If $m<0$ return $0$.
+
INPUT::
x,m -- numbers or symbolic expressions
- Either x or x-m must be an integer.
+ Either m or x-m must be an integer.
OUTPUT::
- number
+ number or symbolic expression (if input is symbolic)
EXAMPLES::
sage: binomial(5,2)
