On 2025-08-27 6:42 p.m., '[email protected]' via sage-devel wrote:
I don't think tests need to be disabled, but rather the CI should notreport a PR as failing if the same failure occurs on develop. So still run the failing tests, but don't report the workflow as failing if the same test fails on develop. I think we already have something like this for the fixed seed tests, but not for the random seeds.That would work for tests where only the output differs sometimes. But the most problems we have at the moment are from random segfaults, and for those it's probably easier to not run them at all instead of trying to filter them out afterwards.
That is a trickier situation. I do think random segfaults should be considered a bug, but also shouldn't cause CI to mark a PR as failing (unless that PR introduced a new random segfault, although that's probably easier to say than detect). As long as we have some CI workflow that still runs and reports those tests (even if only on develop) I think it would be okay to skip them on PRs. I'm not sure what the exact behaviour of #known bug is (does it always skip the test or just in some workflows?), but either that or something like it should work.
-- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/sage-devel/d3ae8de8-3192-4ed0-bdec-d8aa9407fe36%40ucalgary.ca.
