Dear Javier, dear Tim and Axiom developpers,
Thanks Javier for your fine and prompt reviewing work!
On Wed, Oct 14, 2009 at 10:14:12AM -0700, javier wrote:
> - 46 return [GcdDomains()]
> + 46 return [UniqueFactorizationDomains()]
> since all PID's are UFD's it makes more sense to return the category
> of UFD's
> All UFD's are GCD-domains anyway.
Good point (cf. http://en.wikipedia.org/wiki/Principal_ideal_domain)
This inheritance was taken from MuPAD/Axiom. Is anybody in the Axiom
group aware why this was so? Was there some specific hypothesis?
Any other comments anyone?
> * principal_ideal_domains.py
> - 17 The category of unique factorization domains
> + 17 The category of principal ideal domains
Fixed.
> * euclidean_domains.py
> * gcd_domains.py
> * unique_factorization_domains.py
> Positive review
Thanks!
> * integral_domains.py
> Don't understand the line
>
> 40 return [CommutativeRings(), EntireRings()] # TODO: Algebras(R) ?
>
> what would "Algebras(R)" be?
Removed.
Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" <nthi...@users.sf.net>
http://Nicolas.Thiery.name/
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
