Hi Yuri, thanks for working on this topis, it is a nice idea to extract variables from ODE automatically. I vote also for splitting into two patches and if you have problems with this, I can try it to split them by myself. Anyway, the ODE patch depends on the mtype interface and this interface should be the first one which should got positive review.
However giving positive review exceeds my skills. I looked at the code and I have seen that you test (startin gon line 202), if a function equals this or that function. I think that each time when someone adds new symbolic function to Sage (hope someone adds Bessel functions as symbolic functions :), see [1]) or if someone decides to work with another arccot function than sage.functions.trig.Function_arccot, this interface becomes broken. Is there any cleaner way how to implement mtype? I am not clever enough in Pyhton, but I think that a better solution must exist. Thank you for working on this Robert Marik [1] http://groups.google.cz/group/sage-support/browse_thread/thread/10935806a04b79cb/d3f2e3c4a18ff491 On 29 bře, 11:58, "yuri.k" <yuri.karadz...@gmail.com> wrote: > > ivars = set(dvar.arguments()).intersection(extract_var_from_diff(de)) > > I forgot to make intersection in first patch. Changes are in the > second one. > > It helps us to solve > > sage: x,t=var('x > t') > sage: > f=function('f',x) > sage: > g=function('g',t,x) > sage: de=diff(f,x)+f+diff(g,t,x) > sage:desolve(de,f) > (c - integrate(e^x*D[0, 1](g)(t, x), x))*e^(-x) > > without specifying of independent variable. -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org To unsubscribe, reply using "remove me" as the subject.
