Hi,
> > I like this way of seeing. However, I was speaking about module or functions
> > which are not tested nor deprecated and nowhere used into sage (easy to
> > check
> > using grep). Does it make sens to remove them without a deprecation warning
> > ?
> > Many code seems to had been put here, just in case it is useful, and was
> > never
> > used by the sage lib itself, but maybe by some users...
> >
> > Do we agree on the policy:
> >
> > - If a user need a code, he should take care to document and test it.
> > - Corollary: any code which is not tested, nor used can be safely removed
> > without a deprecation warning.
>
> There are functions, classes, methods that were introduced into the
> Sage library well before the policy of 100% doctest coverage was
> implemented and os completely lack testing. It can be difficult to
> know if a piece of orphaned code should be removed. I think we need to
> consider your proposed policy on a module by module basis.
Ok ! That was the purpose of my first e-mail. Let's do it:
sage/monoids/monoid.py
sage/structure/element_py.py
sage/structure/element_verify.py
sage/misc/typecheck.py
They all looks like they should be deprecated and removed... If it's true I
rather improving the doctest coverage by removing them than adding
doctests... However I'd like to have the confirmation that they are indeed
obsolete...
This remark also hold for the following typecheck function in
sage/misc/misc.py
#################################################################
# Type checking
#################################################################
def typecheck(x, C, var="x"):
"""
Check that x is of instance C. If not raise a TypeError with an
error message.
"""
if not isinstance(x, C):
raise TypeError, "%s (=%s) must be of type %s."%(var,x,C)
Florent
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
