On 06/30/10 12:39 AM, François Bissey wrote:
On Jun 29, 4:13 pm, François Bissey<[email protected]>  wrote:
sage doesn't assume that the patch command is installed but rely on cp
being there. That's why patch aren't used.
I agree not ideal but that's a lowest common denominator issue.

Perhaps compare the md5sum of the original and bail if it's not the
expected number? Any time a file changes, the file we replace it with
in the spkg-install should probably change as well. Do our
prerequisites include some checksumming or hashing utility?

that's an interesting idea. On the linux side usually distro do checksums
on packages so it has to be a part of the base system if you want to update.
It's probably the case on most other platform in one way or another.

That wouldn't have taken care of Dave's original problem in any case,
which was double copying the same file. Which I stupidly parroted in Gentoo.

Well, both people had computed a checksum of the original file, and only overwrite that original checksum, the second apply would have failed, since the file would already have been modified.

I would not worry about the fact you have boobed in Gentoo. The first patch added a SunOS-x86 target. The second patch obliterated that Solaris one, so it will be no loss to you in Gentoo.

Francois

--
To post to this group, send an email to [email protected]
To unsubscribe from this group, send an email to 
[email protected]
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to