On 30 June 2010 01:38, Mike Hansen <[email protected]> wrote: > On Tue, Jun 29, 2010 at 5:31 PM, Dr. David Kirkby > <[email protected]> wrote: >> I can't myself see what we gain having the diff and the modified version. >> Even if we stick to using 'cp' (which is a bad idea in my opinion), I would >> much rather create the diff myself if I want to see it. > > The modified version is for copying over. The diff is stored in the > repository so that you don't need to go download old versions of > source code if you want to see what the changes are. > >> Experience tells me that if there is a file called 'diff' it is quite likely >> an old one which someone has not updated. So I personally never trust their >> contents - I'd just rather create it myself if I need it. Since they can't >> be trust, I don't believe they serve a useful function myself. > > The spkg shouldn't get a positive review if those are not up to date.
To give you one specific example, look at latest (python-2.6.4.p9) Python .spkg and you will find the cPickle.c.patch file is 3 months older than the file it should have been generated from. -rw-r----- 1 drkirkby staff 121K Jan 11 20:40 cPickle.c -rw-r----- 1 drkirkby staff 290 Oct 9 2009 cPickle.c.patch Also worth noting is that the Modules.socketmodule.c file in the latest python is 133 KB in size. -rw-r--r-- 1 drkirkby staff 133K May 30 22:38 Modules.socketmodule.c If we removed just those two files from python, that would save us 252 KB of of disk space. The size of the latest version of GNU patch is 248 KB http://ftp.gnu.org/gnu/patch/patch-2.6.1.tar.bz2 So if we added GNU patch, and removed two of the many excess files from Python alone, we would save a few disk space. Dave -- To post to this group, send an email to [email protected] To unsubscribe from this group, send an email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
