On Wed, Oct 27, 2010 at 12:31 AM, Minh Nguyen <nguyenmi...@gmail.com> wrote: > Hi William, > > On Wed, Oct 27, 2010 at 10:54 AM, William Stein <wst...@gmail.com> wrote: >> Hi, >> >> I just spent the day working on code with some people, and using >> http://code.google.com with multiple cloned repositories and their >> code review system, which allows excellent line by line annotation, >> allows much better viewing of file diffs, etc., is really much, much >> better than what we do with trac and the sage referee process. > > Google Code's code reviewing feature certainly provides for fine > grained reviewing. Many times, someone might not have domain expertise > to review a patch. But allowing people to comment on individual lines, > and embed comments into the corresponding lines, means that someone > could point out a typo, another person could point out why a code line > is erroneous, etc. Line-by-line reviewing is something worth exploring > in order to encourage more people to review patches. For example, say > I have provided a patch and uploaded it to trac. Using Google Code, or > any free repository hosting provider, I create a repository of Sage > x.y.z that is patched with the above patch, and the relevant URL to > the repository is provided on the corresponding trac ticket. People > who want to review the patch can review it in the traditional way (the > current way), or do a fine-grained review using line-by-line > annotation. Anyone who has half an hour to spare could just comment on > the individual lines that they feel comfortable reviewing.
The larger problem with the current system is not that it's hard to comment on a single line, but it's way to much work to *fix* a single line. > Note that > this doesn't substitute for actually applying the patch and running > the doctests. Which shouldn't be done by a person anyway... > It would be interesting to see how line-by-line > annotation in code review works out in the long term. I can say from first hand experience, it works well. - Robert -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
