Hi Keshav, On Tue, Dec 14, 2010 at 5:17 PM, Keshav Kini <keshav.k...@gmail.com> wrote: > Hello, > > I have put together a patch which adds a module "sage.graphs.wlrefine" > and implements the Weisfeiler-Leman algorithm for coherent partition / > graph refinement, using an algorithm by Dmitrii Pasechnik and Luitpold > Babel. I have uploaded it here: > > http://www1.spms.ntu.edu.sg/~krkini/temp/sage-wlrefine.patch (to be > applied to the repository in $SAGE_ROOT/devel/sage )
Thank you for your contribution! > As I'm pretty new to sage, I wonder if someone could tell me if I'm > doing everything in the proper way. Your patch adds the following source files to the Sage library: * STABIL.c * STABIL.h both of which are explicitly licensed under the terms of GPLv3. A policy of the Sage project is to include only code licensed under the terms of the GPLv2+ in the Sage library. That means that any code that goes into the Sage library must be covered by the GPL version 2 or any later version, but not explicitly version 3. Here are some options I can think of to remedy the situation: (1) Relicense your C source files under the terms of the GPLv2+, after which you should be able to get your C source files into the Sage library. (2) Create a Sage package (also known as an spkg) and write an interface to your spkg. Anything in the interface that is licensed under GPLv2+ can be included in the Sage library. For everything else, you need to include them in your spkg. See this [1] from sage-devel on options for packaging your code so that the spkg can be distributed with Sage. > Also, is it appropriate to dump .c and .h files into $SAGE_ROOT/devel/ > sage/sage/graphs as I have done, or should I have created a > subdirectory for two files? In fact, is sage.graphs even the correct > place to put this code? I think it's OK to put C source files and their associated headers under sage/graph/, provided that the source files and headers must be well documented, portable, build on all machines that are often used for building Sage from source, etc. But first you need to sort out the issue with licensing as I pointed out above. > There is a comment in STABIL.c which says something about line > continuation and doctests, but this should hopefully be fixed by my > patch at trac #10458 ( http://trac.sagemath.org/sage_trac/ticket/10458 > ). See the following sage-devel thread for discussion on this matter: https://groups.google.com/group/sage-devel/browse_thread/thread/d61251f4ee1429d3 [1] https://groups.google.com/group/sage-devel/msg/92a6e77f35f536ce -- Regards Minh Van Nguyen -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
