On Dec 29, 6:52 pm, Robert Bradshaw <rober...@math.washington.edu>
wrote:
> On Wed, Dec 29, 2010 at 8:58 AM, Simon King <simon.k...@uni-jena.de> wrote:
> > Hi!
>
> > I just noticed that my patch from #10296 (ready for review, improving
> > the communication with singular via pexpect) had bit rotted.
>
> > Of course, the patchbot knew  that the old patch did not apply to the
> > current Sage version. Could the patchbot be modified à la "nagbot" and
> > inform the author of a patch if it fails to apply?

I can see a slight problem with this. At present there's no mechanism
to explain to the patchbot exactly which patches to apply. So if you
have (say) a ticket with a patch that requires a patch from an earlier
ticket to be applied, or if you have three patches of which only the
last two should be applied (because the first was a superseded
attempt), or any other nontrivial situation, the patchbot will be
sending out loads of unnecessary messages.

David

-- 
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to 
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to