On Thu, Dec 30, 2010 at 2:01 AM, Simon King <simon.k...@uni-jena.de> wrote: > Hi Dave, > > On 30 Dez., 10:21, daveloeffler <dave.loeff...@gmail.com> wrote: >> I can see a slight problem with this. At present there's no mechanism >> to explain to the patchbot exactly which patches to apply. So if you >> have (say) a ticket with a patch that requires a patch from an earlier >> ticket to be applied, or if you have three patches of which only the >> last two should be applied (because the first was a superseded >> attempt), or any other nontrivial situation, the patchbot will be >> sending out loads of unnecessary messages. > > I may be mistaken, but as far as I know, if ticket #9876 has 4 patches > A.patch,...,D.patch, of which only D, B and C are to be applied, after > applying the patches from ticket #9999 and #8888, you simply need to > provide a comment that contains the lines > > depends on #9999, #8888 > apply D.patch, B.patch, A.patch > > So, the patchbot would only send out a message if one forgot to > indicate how the patches should be applied (which is an important > information anyway).
And otherwise it does a "best guess" kind of approach, which is decent (especially if there is only one patch :). In any case, I don't think people would mind getting a "nag" that the patchbot got confused, indicating that it might be worth your while to give it a hint. - Robert -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
