On Thu, Mar 22, 2012 at 10:32 AM, Jason Grout <jason-s...@creativetrax.com> wrote: > On 3/22/12 10:22 AM, William Stein wrote: >> >> On Thu, Mar 22, 2012 at 10:19 AM, Jason Grout >> <jason-s...@creativetrax.com> wrote: >>> >>> On 3/21/12 7:34 PM, Julien Puydt wrote: >>>> >>>> >>>> Hi, >>>> >>>> yesterday I noticed that there are many places in sage's sources (I >>>> only checked in the sage spkg) where inclusions are made with a >>>> filename which looks like ../../../../../whatever (no exageration: up to >>>> *five* levels!). >>>> >>>> Shouldn't those be removed, and the right path added to the include >>>> line? >>> >>> >>> >>> What is the "right path"? >>> I thought the paths should be relative so that >>> sage could be moved. >> >> >> This is only used at build time by Cython. >> The right path depends -- it could be SAGE_ROOT/devel/sage/sage/ext in >> some cases... >> > > > To clarify, we're talking about the relative paths we see in many pyx files > in the sage library, right? When you say "build time", you mean Build time > of the module, right? So if I change the pyx file and do sage -br, the path > matters, right? > > Are you suggesting something like: > > include os.path.join(os.env['SAGE_ROOT'], 'devel', 'sage','sage','ext') > > so that the "right path" is recomputed any time the module is recompiled?
Yep. That's what is done in psage. > (I suppose it would be nice to have one more environment variable, > SAGE_LIBRARY, that would point to SAGE_ROOT/devel/sage/sage, so that the > above would be: > > include os.path.join(os.env['SAGE_LIBRARY'], 'ext') Please, not another environment variable! -- William > > > ) > > Thanks, > > Jason > > > -- > To post to this group, send an email to sage-devel@googlegroups.com > To unsubscribe from this group, send an email to > sage-devel+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org -- William Stein Professor of Mathematics University of Washington http://wstein.org -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
