On Friday, April 5, 2013 7:37:20 AM UTC+2, Snark wrote: > > Le 05/04/2013 07:29, leif a �crit : > > Julien Puydt wrote: > >> Le 05/04/2013 03:28, leif a �crit : > >>> Or otherwise ask John Cremona... ;-) > >> > >> I suggest to provide him a patch adding the #include at the top of one > >> of the files. > > > > Yep, but better where int64_t is actually used, i.e., in the mentioned > > #else part in xmod.h, and probably some other places (see below). > > I'm not sure it makes sense to over-optimize where the file is included: > it's a system include widely available, so there's little interest to > restrict its visibility. > I think including <stdint.h> at the top of xmod.h is fine and works fine. the other files using int64_t are included from files including arith.h which include xmod.h.
> > > P.S.: > > > > Apparently int64_t is also used in libsrc/smat_elim.cc, > > libsrc/smat.cc and libsrc/svec.cc; haven't checked which files include > > these, or where these get the definition from. > > So you see my point about just including it at the top of one of the > main headers of eclib and be done :-P > > Snark on #sagemath > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
