On 2014-09-23 18:36, John Cremona wrote:
Well done.    Surely if all those hunderds of lines now look good,
that counts for a large number of tests that Volker did it right?  If
so, I think you can give the ticket a positive review...
I'm not so sure. For example, the last version of the patch accidentally disabled all doctests for plotting, a fact which could *easily* have been overlooked by a reviewer.

I really would like somebody else (preferably somebody who knows about IPython and displayhooks) to review that part of the ticket.

--
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to