Hi Martin, There are a *lot* of tickets which are short, fix bugs, increase speed and are waiting for reviews. If all authors are advertising their tickets it will become a nightmare on sage-devel.
If you want your ticket reviewed, it would be better: - looks for somebody that is likely to do the review and e-mail him personally - review another ticket and ask for a review back Best, Vincent On 17/05/15 11:28, Martin Albrecht wrote: > Hi all, > > http://trac.sagemath.org/ticket/18320 fixes a performance issue with > polynomial sequences which are used for multivariate polynomials to e.g. > store > Gröbner bases and stuff. The patch is very short, it would be nice if someone > could look at it as it makes a huge difference for large systems: > > > diff --git a/src/sage/rings/polynomial/multi_polynomial_sequence.py > b/src/sage/rings/polynomial/multi_polynomial_sequence.py > index 8a3786d..6567629 100644 > --- a/src/sage/rings/polynomial/multi_polynomial_sequence.py > +++ b/src/sage/rings/polynomial/multi_polynomial_sequence.py > @@ -311,11 +311,14 @@ def PolynomialSequence(arg1, arg2=None, > immutable=False, > cr=False, cr_str=None): > > try: > e = next(iter(gens)) > - > - try: > - parts = tuple(map(ring, gens)), > - except TypeError: > + # fast path for known collection types > + if isinstance(e, (tuple, list, Sequence_generic, > PolynomialSequence_generic)): > parts = tuple(tuple(ring(f) for f in part) for part in gens) > + else: > + try: > + parts = tuple(map(ring, gens)), > + except TypeError: > + parts = tuple(tuple(ring(f) for f in part) for part in gens) > except StopIteration: > parts = ((),) > > Cheers, > Martin > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
