Hello Jori, When in front of a patch I do not agree with, the least harmful thing I can do to the author's work is to not review it. Especially when I consider that it is only a matter of taste, and thus do not oppose any positive review given by somebody else to the very same patch.
Especially when I still read the code and try to find improvements, while knowing that I will not review it in the end. The incitation, however, looks healthy: when your code is being reviewed, your code will pass faster if you can reach an agreement with the reviewer... I don't see how we could be led to have a unified view on things, however. This software is the common work of people who care enough about it to disagree on very minor details :-) Nathann Le 25 janv. 2016 09:27, "Jori Mäntysalo" <jori.mantys...@uta.fi> a écrit : > There was a discussion between I, Travis and Nathann about > HasseDiagram-Poset; maybe a year ago there was discussion about 'self' in > docstrings. > > I have made some simple functions to add to Sage. Most of them have been > reviewed and accepted. Now, if I ask Nathann to review a function that uses > Poset class only as a wrapper, he rejects them (but makes good suggestions > for the code). If Travis is reviewing, he rejects modifications where > "self" is changed to "this thing" (but makes good suggestions for the > docstring). (Well, I can also ask Frédéric and get a positive review (with > good comments about making the code PEP-compliance).) > > This is kind of complicated. If this is just me, then forget this mail. > But do other have similar feelings about need of common view of some > details? > > -- > Jori Mäntysalo > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
