On Fri, Sep 7, 2018 at 6:27 PM Timo Kaufmann <eisfre...@gmail.com> wrote: > > > > Am Freitag, 7. September 2018 17:56:04 UTC+2 schrieb Erik Bray: >> >> On Fri, Sep 7, 2018 at 5:29 PM Timo Kaufmann <eisf...@gmail.com> wrote: >> > >> > For what its worth, we currently don't apply any patches in nix and at >> > least the sage doctests pass. A more standard build would still be nice >> > though. And since upstream is officially dead, I think giving it a new >> > home would be very good. +1 from me. >> >> Most of the patches are build-related and test-related fixes, many of >> which seem to stem from issues on OSX. > > > We build it on OSX too. We only run `make check` though, not `make test`. I > can't verify if that would pass on darwin since I don't own a mac.
Well, a lot of these patches are pretty old too. Who knows if they're still really relevant. Most of them seem harmless enough so I've gone ahead and applied them. I also applied the patches I need to build correctly on Cygwin. A bit later I will work on autotoolizing it, but in the short term I might go ahead and make a release based on the patches applied above, as I really need it for the Cygwin fixes which are a release blocker. >> >> >> >> > Am Freitag, 7. September 2018 15:53:43 UTC+2 schrieb Erik Bray: >> >> >> >> Hi all, >> >> >> >> Does anyone know what that current status is of the upstream zn_poly >> >> package? According to its website >> >> http://cims.nyu.edu/~harvey/zn_poly/ it is "no longer maintained", >> >> though it has been re-released under a BSD-compatible license. >> >> >> >> Since its last upstream release the package for it in Sage has >> >> accumulated a number of patches as well, and I believe I may need to >> >> add one more patch to it for building properly on Cygwin :( See >> >> https://trac.sagemath.org/ticket/26050 >> >> >> >> If it's alright, I would propose creating a new repository for it >> >> under the sagemath gitlab organization (or GitHub) which would become >> >> the new "upstream" for zn_poly. Then we can merge in all these >> >> patches; maybe even implement a new, more standard build system (I >> >> would be happy to do this). In fact the current "build system" is >> >> going to have problems long-term, as it currently consists primarily >> >> of a Python script that will not work, as written, on Python 3. >> > >> > -- >> > You received this message because you are subscribed to the Google Groups >> > "sage-devel" group. >> > To unsubscribe from this group and stop receiving emails from it, send an >> > email to sage-devel+...@googlegroups.com. >> > To post to this group, send email to sage-...@googlegroups.com. >> > Visit this group at https://groups.google.com/group/sage-devel. >> > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at https://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
