On Tue, Oct 2, 2018 at 4:44 PM Nathan Dunfield <nat...@dunfield.info> wrote: >> >> It's bad packaging by upstream: it's running Cython but the Cython >> source files are not in the snappy source tarball. > > > Yes, we ship the Cython generated C/C++ files rather than Cython code itself. > My understanding from the Cython docs is that this is the recommended > approach for non-Sage packages, and we have always done this.
Really? Could you point out the place in the docs that recommends this? Letting Cython to do necessary adjustments for the target C/C++ compiler seems like the most natural thing to do... > But apparently we accidentally introduced a bug in the setup.py script in > SnapPy 2.6 that is causing it to look for the Cython files anyway... > > Nathan > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at https://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
