On Thu, Feb 7, 2019 at 5:05 PM E. Madison Bray <erik.m.b...@gmail.com> wrote:
>
> On Thu, Feb 7, 2019 at 4:53 PM Jeroen Demeyer <j.deme...@ugent.be> wrote:
> >
> > On 2019-02-07 16:45, E. Madison Bray wrote:
> > > Apparently Jeroen argued about this with the IPython developers some
> > > time ago: https://github.com/ipython/ipython/pull/9867
> >
> > Indeed. Your post did seem familiar to me, but I actually forgot about
> > that discussion.
>
> FWIW we are on a rather old prompt_toolkit (1.0.9), whereas the
> current version is 2.0.7.  Newer versions of IPython have also
> upgraded to depend on prompt_toolkit >= 2.0.  It's possible then that
> this situation has been improved already, but I am not sure.  Sage
> still uses IPython 5.x since it is an LTS release.

Alas, I tried IPython 7 in a virtualenv and the situation is no
better.  The logic for handling the KeyboardInterrupt isn't even
right: It catches the KeyboardInterrupt, then calls
self._eventloop.stop(), but then rather than break out of IPython's
mainloop function it just continues the loop and tries to call
self.interact() with a no longer functioning prompt, and then crashes.
As a bonus, leaving my terminal in an extremely broken state.

This stuff is hard to get right, but still, no bueno... :(

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to