When building open-source software, it is not unusual to see a few compiler
warnings - usually deprecated code. There's quite a lot of them in Sage.

But looking at lcalc, the code seems particularly poor, with lots of unused
variables & deprecated code. It does not exactly inspire confidence in Sage.
I don't know how it possible to check code core correctness under such
circumstances.

tmp_x is unused. I thought that would be defined in a C or C++ file, not a
header file. Lfind_zeros.h It's actually normal practice to have code in C
and C++ files, not header files.

Functions are declared to return values, but do not do so. 'missing_data' is
unused. Is that since it's not needed, or because the author forget to use
it, so the code is unstable?

There are reports of "deprecated or antiquated header which may be removed
without further notice at a future date".

Unfortunately, lcalc was the part of Sage I intended using - now I think I
will look at other software. Hopefully some high quality open-source
software. Parts of the code are quite well commented, but other parts have
few if any comments. This has rather put me off.

Anne

-- 
To post to this group, send email to sage-support@googlegroups.com
To unsubscribe from this group, send email to 
sage-support+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/sage-support
URL: http://www.sagemath.org

Reply via email to