The antiquated header files and unused variables have been removed in L-1.3,
which has not yet been released to the public. It should be released in the
next couple of weeks.
Best,
Mike
On Tue, 8 Jun 2010, William Stein wrote:
On Tue, Jun 8, 2010 at 12:21 PM, Anne Driver <annedrive...@gmail.com> wrote:
When building open-source software, it is not unusual to see a few compiler
warnings - usually deprecated code. There's quite a lot of them in Sage.
But looking at lcalc, the code seems particularly poor, with lots of unused
variables & deprecated code. It does not exactly inspire confidence in Sage.
I don't know how it possible to check code core correctness under such
circumstances.
The person who wrote Lcalc is easily the world leader in algorithms
for numerical
computation of zeros of L-series of all types, and has done vastly
more along these
lines than anybody else. I would greatly prefer code with unused variables
from a person that understands the relevant mathematics, than the
other way around.
tmp_x is unused. I thought that would be defined in a C or C++ file, not a
header file. Lfind_zeros.h It's actually normal practice to have code in C
and C++ files, not header files.
Functions are declared to return values, but do not do so. 'missing_data' is
unused. Is that since it's not needed, or because the author forget to use
it, so the code is unstable?
Maybe you should ask the author...
There are reports of "deprecated or antiquated header which may be removed
without further notice at a future date".
Unfortunately, lcalc was the part of Sage I intended using - now I think I
will look at other software. Hopefully some high quality open-source
software. Parts of the code are quite well commented, but other parts have
few if any comments. This has rather put me off.
Good luck.
-- William
Anne
--
To post to this group, send email to sage-support@googlegroups.com
To unsubscribe from this group, send email to
sage-support+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/sage-support
URL: http://www.sagemath.org
--
William Stein
Professor of Mathematics
University of Washington
http://wstein.org
--
To post to this group, send email to sage-support@googlegroups.com
To unsubscribe from this group, send email to
sage-support+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/sage-support
URL: http://www.sagemath.org
