I don't think that will work if you are relying on the error message to indicate the wrong length of input. For example:
sage: AdditiveAbelianGroup([6,2]) Additive abelian group isomorphic to Z/2 + Z/6 Now you will expect the element (1,0) to have order 6 but it has order 2. John On 28 April 2014 14:09, Nathann Cohen <nathann.co...@gmail.com> wrote: > > Its always going to be somewhat confusing to have both the original > > definition and a canonical form around. Feel free to add more descriptive > > construction methods for elements. The ctor argument convention is > because > > that was chosen originally and I didn't want to break code when > refactoring > > it for libgap. > > What do you think the implications of the following changes would be ? > > - if isinstance(x, (list,tuple)): > - try: > - x = self.optimized()[0].V().linear_combination_of_basis(x) > - except ValueError as msg: > - raise TypeError(msg) > - elif isinstance(x, FGP_Element): > + if isinstance(x, FGP_Element): > x = x.lift() > return self.element_class(self, self._V(x)) > > This changes the codes that appears in : > > sage: g=groups.misc.AdditiveAbelian([4,3,3,5]) > sage: g._element_constructor?? > > The thing is that I really know nothing about groups, nothing about > their implementation in Sage, and that I have no idea what the impact > of such changes can be .... :-/ > > Nathann > > -- > You received this message because you are subscribed to the Google Groups > "sage-support" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-support+unsubscr...@googlegroups.com. > To post to this group, send email to sage-support@googlegroups.com. > Visit this group at http://groups.google.com/group/sage-support. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sage-support" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-support+unsubscr...@googlegroups.com. To post to this group, send email to sage-support@googlegroups.com. Visit this group at http://groups.google.com/group/sage-support. For more options, visit https://groups.google.com/d/optout.
