The branch, master has been updated via e36622f s4-upgradedns: Make sure the attribute exists before accessing it from 3be2af1 Add DEBUG statements to show when access has been denied and why.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit e36622f92616b6982bf875563728dc8cdf97c93c Author: Amitay Isaacs <ami...@gmail.com> Date: Wed Mar 28 17:49:09 2012 +1100 s4-upgradedns: Make sure the attribute exists before accessing it Autobuild-User: Amitay Isaacs <ami...@samba.org> Autobuild-Date: Wed Mar 28 10:27:40 CEST 2012 on sn-devel-104 ----------------------------------------------------------------------- Summary of changes: source4/scripting/bin/samba_upgradedns | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/scripting/bin/samba_upgradedns b/source4/scripting/bin/samba_upgradedns index 1a42e0c..86172a7 100755 --- a/source4/scripting/bin/samba_upgradedns +++ b/source4/scripting/bin/samba_upgradedns @@ -379,12 +379,16 @@ if __name__ == '__main__': msg = msgs[0] master_nclist = [] - for nc in msg["msDS-hasMasterNCs"]: - master_nclist.append(nc) + ncs = msg.get("msDS-hasMasterNCs") + if ncs: + for nc in ncs: + master_nclist.append(nc) partial_nclist = [] - for nc in msg["hasPartialReplicaNCs"]: - partial_nclist.append(nc) + ncs = msg.get("hasPartialReplicaNCs") + if ncs: + for nc in ncs: + partial_nclist.append(nc) modified = False for nc in dns_nclist: -- Samba Shared Repository