On Fri, Mar 30, 2012 at 08:52:09PM -0700, Jeremy Allison wrote: > On Fri, Mar 30, 2012 at 06:02:06PM -0700, Matthieu Patou wrote: > > At least for this two changes you didn't get completely the sense of > > the strlcpy(), the idea is that if you have > > fe80::221:ccff:fe5f:7e51%eth0 to get the number of the interface and > > remove what is after '%'. > > so we should in this case always truncate and ihmo it's not a problem. > > Ok - I'm boilerplate fixing all strlcpy uses. If it truncates > then by definition it's a problem, and we shouldn't be using > strlcpy() - we should be correctly paying attention to > the length we really want. > > I do (vaguely :-) remember writing this code (or something > like it). I'll take a look and fix up asap.
Ah yes - now I looked at it I did write this code originally :-). I'll fix. Jeremy.