Hi Hynek, Thanks! I wrote my answers on the github issue-tracker. As I wrote and explained there, the taxes are being calculated right. In my example it's just looking complicated because I have to calculate a 2% discount of the total and then apply it (add it) "regresively" to the products-discount, so it gets handled as a "discount" and appears on the checkout-screens and payments, etc. etc. This, and the example with the shipping-options, were just the best ways I found to achieve all our customizations and at the same time to use as much as possible from the core.
But, all in all, the examples are just examples and only showing a little part of what kind of possible usage could be achieved with this core-changes. They are not meant to be applied to the core, of course, so the tax-calculation part, even if it was wrong in my example, wouldn't have to be fixed ;-) I think that, if we get this right, it could give us the possibility to customize almost everything that has to do with payment and shipping options without ever touching the core and having to override anything, and the new signals would have a minimal impact on the core- code. Well, I hope my new comments and example-additions won't confuse you even more ;-) and thanks again for looking into this. I'll be looking forward for your next feedback! Andrea On Dec 24, 5:44 am, hynekcer <[email protected]> wrote: > Andrea, now I have written comments to your enhancement and patch for > additional charges. > It reqires many improovments, especially correct tax. > > -- Hynek > > On 22 pro, 23:01, adlh <[email protected]> wrote: > > > > > > > > > Hi, > > > I posted an issue in bitbucket some time ago. In my case, it is was > > more general issue though. As I not only wanted to add some charges > > for some specific module, but I needed a flexible way, to be able to > > add charges or shipping discounts (i.e. 5% from the order's total) > > depending on the shipping/payment-method, the order-total AND shipping > > location. > > I couldn't find a way to achieve this, without modifying the core > > code. So I proposed a new signal and a mini-change to the core-code to > > be able to handle this, without messing with the core code. > > > Here is a link to the bitbucket > > issue:https://bitbucket.org/chris1610/satchmo/issue/1351/satchmo-payment-an... > > > I would love to here some feedback :-) > > > Thanks > > Andrea > > > On 21 Dez., 22:22, Chris Moffitt <[email protected]> wrote: > > > > If someone wants to write up a patch to add a configurable shipping > > > charge, > > > I would be happy to do it. It's not tough to do but I'm not sure I'll get > > > to it right away. > > > > -Chris > > > > On Wed, Dec 21, 2011 at 12:49 PM, Joe K <[email protected]> wrote: > > > > Thanks Dave, > > > > > That certainly seems like an easy solution, and will work. So I will > > > > probably go that route, at least for the short-term. > > > > > It seems like this is something that FedEx would allow you to > > > > associate with your account...and maybe they do. I have my client > > > > looking into that with their account now. It would be nice if the > > > > client could control how much additional charge gets tacked on without > > > > me messing with anything. > > > > > Worst case isn't so bad, and that would be modifying the FedEx module > > > > to allow you to add a handling charge. I know Chris is actively > > > > working on that puppy, so maybe if I'm patient the capability will > > > > magically appear ;-) (Not that I'm averse to contributing something > > > > back...happy to if I get to it before Chris does.) > > > > > Thanks again. > > > > > Joe > > > > > On Dec 21, 11:35 am, Dave Brown <[email protected]> wrote: > > > > > USPS does this, not sure why its not there for fedex. I ended up > > > > > inheriting the module and add it into the def cost() function in > > > > shipper.py > > > > > > Dave > > > > > > On Wed, Dec 21, 2011 at 1:23 PM, Joe K <[email protected]> wrote: > > > > > > Just drumming this up again, since I'm finally getting around to > > > > > > implementing this. > > > > > > > I don't see anything in the FedEx module that allows me to add a > > > > > > "handling" charge. Any tips for adding $5 to every order? > > > > > > > Thanks. > > > > > > > Joe K > > > > > > > -- > > > > > > You received this message because you are subscribed to the Google > > > > Groups > > > > > > "Satchmo users" group. > > > > > > To view this discussion on the web visit > > > > > >https://groups.google.com/d/msg/satchmo-users/-/wFPw2Zj4XnEJ. > > > > > > To post to this group, send email to [email protected]. > > > > > > To unsubscribe from this group, send email to > > > > > > [email protected]. > > > > > > For more options, visit this group at > > > > > >http://groups.google.com/group/satchmo-users?hl=en. > > > > > > -- > > > > > Dave Brown > > > > > CEO/Founder > > > > > Rampframe.com - Action Sports Network > > > > > -- > > > > You received this message because you are subscribed to the Google > > > > Groups > > > > "Satchmo users" group. > > > > To post to this group, send email to [email protected]. > > > > To unsubscribe from this group, send email to > > > > [email protected]. > > > > For more options, visit this group at > > > >http://groups.google.com/group/satchmo-users?hl=en. -- You received this message because you are subscribed to the Google Groups "Satchmo users" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/satchmo-users?hl=en.
