Review: Needs Fixing

Hi El Hadji,

Thanks for your contribution. As for the review I have this 2 points that you 
can improve.

l.100.103.132: Even in 6.1 the osv is considered deprecated (osv.osv actually 
points to orm.Model) so for the import is better to use "from openerp.osv 
import orm, fields" and for the models it's better to inherit from orm.Model 
istead of osv.osv.

l.129.137: In 6.1 we don't need to instantiate the model after defining it.


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/experience/+merge/194926
Your team Savoir-faire Linux' OpenERP is subscribed to branch 
lp:~savoirfairelinux-openerp/openerp-hr/experience.

-- 
Mailing list: https://launchpad.net/~savoirfairelinux-openerp
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~savoirfairelinux-openerp
More help   : https://help.launchpad.net/ListHelp

Reply via email to