Review: Needs Fixing code review, no tests

Hi,

Thanks for the contrib. A few remarks:

 * Line 27-29 use from . import XY
 * From a security point of view, is the hr_user the right person to create and 
delete the hr.academic, hr.professionnal, hr.certification object ? I would may 
be suggest hr_manager instead for that while keeping hr_user the read right, 
what do you think ?

Regards,

Joël
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/experience/+merge/194926
Your team Savoir-faire Linux' OpenERP is subscribed to branch 
lp:~savoirfairelinux-openerp/openerp-hr/experience.

-- 
Mailing list: https://launchpad.net/~savoirfairelinux-openerp
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~savoirfairelinux-openerp
More help   : https://help.launchpad.net/ListHelp

Reply via email to