Hi all ! [ I don't know if balbinus is reading this mailing list, but I don't acutally have his email.. ]
I've been looking at harbor.ml in order to get some review on the actual code. My first remark would be that it uses a *lot* of code from http_source.ml.. Indeed, a move to sources/ and a simple open Http_source and inherit allowed to compile a harbor where only different things from http are used.. I don't know how it should be problematic, but I would recommend to use http's code as it seems to work like a charm here.. Other remark is a debugging feature: current harbor thread does not respect the paradigm with Tutils: although the begining of client handling is done the same way as for telnet, as soon as a client is connected and a request is handled, then no hand is given back to main thread, so the thread is locked. On the other hand, any source connection is supposed to be infinite, so I don't know if this is pertinent to use a single thread for each input.harbor.. My solution would be to move source's part of harbor to sources/, then start a server from tools/ with a proper thread when set to. Then when input script is parsed, it would create another thread to which handling of source is given when the server receives a request. I have implemented this, but I wanted everyone's feelings before doing anything. I'm also quite ok to implement icy's dirty passing to server: GET request on /admin/metadata?mode=updinfo&mount=/test.ogg&title=Man%20of%20the%20Living&artist=Wayne%20Wade&album=Black%20Is%20The%20Color&song=Wayne%20Wade%20%2d%20Man%20of%20the%20Living. Huummmmm :) Romain -- They swapped my brother now, also, my sister too for a drink of wine, so they could drink and be merry, so they could drink and be merry.
