Le Saturday 08 September 2007 14:02:15 Vincent Tabard, vous avez écrit :
> Hi
Hi !
> > My first remark would be that it uses a *lot* of code from
> > http_source.ml.. Indeed, a move to sources/ and a simple open Http_source
> > and inherit allowed to compile a harbor where only different things from
> > http are used.. I don't know how it should be problematic, but I would
> > recommend to use http's code as it seems to work like a charm here..
> >
>
> Agreed.
Nice !
> > On the other hand, any source connection is supposed to be infinite, so I
> > don't know if this is pertinent to use a single thread for each
> > input.harbor..
> >
>
> Mmm. I'd rather say that we should use one thread per client (which
> translates indeed into one per input.harbor, but remember we're building
> a server ;).
That's what I propose !
> I also agree with your other proposals (splitting into two parts).
Nice !
I actualy don't think it would be clean to separate it, or at least it would
require some attention at build: harbor server code has know the type of the
input class, so in case of two different files, the sources/harbor_input.ml
would have to be compiled before tools/harbor.ml...
Or we could think of a more complicated paradigm, but I don't think we need
extra complexity here... :)
It's nice you agree with my proposal, I think I'll beging this on tomorow..
Romain
--
Preacherman, don't tell me,
Heaven is under the earth.
I know you don't know
What life is really worth.
It's not all that glitters is gold;
'Alf the story has never been told:
So now you see the light, eh!
Stand up for your rights. Come on!
