Yo, Thanks for the feature! The patch looks rather natural. Just two remarks.
You added a depedency on Str. Is that new because of Syslog, or was that needed already before? Also, do we really need to specify the dependency since Str is in the default library? Note that Str isn't thread safe (the API for looking up the matched groups) and so we should avoid it. Perhaps it's a good time to move to Pcre (as in liquidsoap) and at least don't add new uses of Str. For the custom loggers you could use a simple list and remove a function by comparing it (using ==) with the elements of the list. This is a general remark about several of our plugin systems, I think it occurred to me only now becauseof the hash tables, which I consider heavy (this has to do with some childhood trauma... no kidding). Cheers, David ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Savonet-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/savonet-devl
