Hey,
It seems this patch did not raise any further comments after David's.
I proposed then to commit it if no one objects.
Romain
Le jeudi 24 juin 2010 18:35:30, Romain Beauxis a écrit :
> Le jeudi 24 juin 2010 18:21:12, David Baelde a écrit :
> > Yo,
>
> Hey !
>
> > Thanks for the feature! The patch looks rather natural. Just two remarks.
>
> Thanks !
>
> > You added a depedency on Str. Is that new because of Syslog, or was
> > that needed already before? Also, do we really need to specify the
> > dependency since Str is in the default library?
> >
> > Note that Str isn't thread safe (the API for looking up the matched
> > groups) and so we should avoid it. Perhaps it's a good time to move to
> > Pcre (as in liquidsoap) and at least don't add new uses of Str.
>
> Str is a dependency of dtools. I could be another goal to remove it.
> However, its compilation would then require pcre, which may or may not be
> a nice thing.
>
> > For the custom loggers you could use a simple list and remove a
> > function by comparing it (using ==) with the elements of the list.
> > This is a general remark about several of our plugin systems, I think
> > it occurred to me only now becauseof the hash tables, which I consider
> > heavy (this has to do with some childhood trauma... no kidding).
>
> Heh :)
>
> I was looking for the most natural way of registering imperative lists of
> values. If you think a list is better, I'm ok for it. On the other hand,
> the idea of having a (name,method) hashtbl makes it possible to list the
> registered methods, although it is not implemented yet.
>
> Another bit that I forgot: the current implementation does not account for
> the semantics of syslog's levels, INFO, WARN, ERR etc..
>
> Ideally, it would be nice to also have that in dtools. However, setting the
> log level requires the use of the Conf API, which at the moment only
> accepts a limited set of types, and in particular no abstract types. This
> may be extended but, then, how would we implement this in liq using
> set("log.level", Error) ?
>
>
> Romain
>
> ---------------------------------------------------------------------------
> --- ThinkGeek and WIRED's GeekDad team up for the Ultimate
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> lucky parental unit. See the prize list and enter to win:
> http://p.sf.net/sfu/thinkgeek-promo
> _______________________________________________
> Savonet-devl mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/savonet-devl
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Savonet-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-devl
