Failures / sleeps in v4l plugin
-------------------------------

                 Key: LS-439
                 URL: http://dev.sourcefabric.org/browse/LS-439
             Project: Liquidsoap
          Issue Type: Bug
          Components: Liquidsoap
            Reporter: Samuel Mimram
            Assignee: Samuel Mimram


We should make input.v4l faillible (it can fail when the webcam is not 
available or unplugged).

Moreover, we should maybe also address this comment by David :

"When they are turned off (#sleep) operators should free resources that they 
have allocated. Now that this operator allocates a thread, it should make sure 
the thread exits when the operator exits - it's also important in order to 
avoid having two polling threads if the operator is re-initialized. This can be 
done synchronously or not. We have similar problems with several other 
operators, and quite a bit of duplicated and clumsy code, which we should 
factorize and cleanup at some point."

I am not sure that it really applies here though: the thread is created when 
the object for the operator is created (not when the operator is initialized). 
The polling thread is blocked on a condition which is signaled in get_frame: 
when the operator is sleeping, the thread simply gets blocked on the condition 
so it's not such a big problem...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
Savonet-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-devl

Répondre à