[
http://dev.sourcefabric.org/browse/LS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663#action_15663
]
Romain Beauxis commented on LS-439:
-----------------------------------
Ok, I have just commited a branch addressing this issue.
It turned out that the Ioring structure was a perfect match for this operator!
I did not address the faillability point. In fact, most hardware IO are
infallible with the assumption that if the hardware is not present upon
starting then we fail and that the hardware should not be removed during an
execution.
I think we can also stick with that for v4l..
> Failures / sleeps in v4l plugin
> -------------------------------
>
> Key: LS-439
> URL: http://dev.sourcefabric.org/browse/LS-439
> Project: Liquidsoap
> Issue Type: Sub-task
> Components: Liquidsoap
> Reporter: Samuel Mimram
> Assignee: Romain Beauxis
> Priority: Blocker
>
> We should make input.v4l faillible (it can fail when the webcam is not
> available or unplugged).
> Moreover, we should maybe also address this comment by David :
> "When they are turned off (#sleep) operators should free resources that they
> have allocated. Now that this operator allocates a thread, it should make
> sure the thread exits when the operator exits - it's also important in order
> to avoid having two polling threads if the operator is re-initialized. This
> can be done synchronously or not. We have similar problems with several other
> operators, and quite a bit of duplicated and clumsy code, which we should
> factorize and cleanup at some point."
> I am not sure that it really applies here though: the thread is created when
> the object for the operator is created (not when the operator is
> initialized). The polling thread is blocked on a condition which is signaled
> in get_frame: when the operator is sleeping, the thread simply gets blocked
> on the condition so it's not such a big problem...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Savonet-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-devl
