[
http://dev.sourcefabric.org/browse/LS-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487#action_15487
]
Romain Beauxis commented on LS-495:
-----------------------------------
I have nothing against a more general mechanism for ressources allocated by
sources.
The reason why I decided to tackly this issue is that I do believe it should be
fixed in 1.0. We are advertising more and more the use of dynamic source
creation and I believe that if those sources do not unregister their commands
then that feature is kind of useless..
Concerning the namespace, we do want to unregister it. If once dymanic source
is create with id "foo", destroyed and then later the same code is used to
create a new "foo" source then the new source will register the namespace
"foo.1" which is not what we expect..
Setting the operators'id to the namespace returned by the server is also
probably a good idea. We already have code that call "#{source.id(s)}.skip" and
things like that, where ze really expect source.id and server's namespace to be
identical.
Finally, as this discussion reveals, those mechanisms are not obvious.
Therefore, I do think that namespace mamagement needs to be factorized
otherwise, we will end-up with identical code duplication ((which is already
the case) and bug-prone situations..
> Deregister telnet commands on source's sleep
> --------------------------------------------
>
> Key: LS-495
> URL: http://dev.sourcefabric.org/browse/LS-495
> Project: Liquidsoap
> Issue Type: Bug
> Affects Versions: 1.0
> Reporter: Romain Beauxis
> Priority: Important
>
> Server/telnet command needs to be unregistered each time a source is shutdown
> in order to allow it to be garbage collected (and also to not polute..)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software
be a part of the solution? Download the Intel(R) Manageability Checker
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
Savonet-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-devl
