Re: [Sawfish] Re: odd window resize behaviour with firefox/thunderbird 17.0

[Stefan Husmann]

Am 24.11.2012 15:51, schrieb Michael Panteleit:

Michael Panteleit <m...@netcologne.de> writes:

Is it possible that the ridiciolous high "specified maximum size" causes
an overflow?

FF-17.0:
WM_NORMAL_HINTS(WM_SIZE_HINTS):
                program specified minimum size: 18 by 142
                program specified maximum size: 1073741824 by 1073741824
                window gravity: NorthWest

I guess it is. I patched src/windows.c so that max_width and max_height
is capped at 2000;

diff -wNaur sawfish-1.9.1/src/windows.c mySawfish-1.9.1/src/windows.c
--- sawfish-1.9.1/src/windows.c 2012-09-01 10:47:01.000000000 +0200
+++ mySawfish-1.9.1/src/windows.c       2012-11-24 15:37:29.967950229 +0100
@@ -1297,6 +1297,11 @@
      hints = &VWIN(win)->hints;
      flags = hints->flags;

+    if (hints->max_width >= 2000)
+        hints->max_width = 2000;
+    if (hints->max_height >= 2000)
+        hints->max_height = 2000;
+
      /* Some sanity checking */
      if ((flags & PMinSize)
        && (hints->min_width < 0 || hints->min_height < 0))


and the problems with Firefox 17.0 vanishes. I have the maximze-button
again and I can resize the window normally.

This of course is not a patch to release, it's just the prove that the
settings from Firefox are the problem.

Greetings,
Michael

Hello,

I am using Arch Linux and have similar problems, except

- I am using thunderbird and conkeror (depends heavily on xulrunner), no firefox
- I _have_ a maximize button, but it does not work.

Your patch solves this issue for me. Many thanks!

Best Regards Stefan

--
Sawfish ML