2011/11/4 Brian Holt <[email protected]>:
> @pprett:  Thanks for doing the hard work to change the tree into a numpy
> representation.  I have been thinking a lot about it, and I was just about
> to implement it, but you've got there first. I have a few suggestions after
> looking at your code that I'd like to try out, so I might make a clone.

Thanks Brian - I appreciate that. Lets do the code review on github,
that's more convenient.

BTW: in case somebody is keen on vectorizing and advanced indexing
take a look at `apply_tree` in _tree.py. With some modifications of
the tree representation it might be possible to vectorize the for
loop...

>
>
>
> ------------------------------------------------------------------------------
> RSA(R) Conference 2012
> Save $700 by Nov 18
> Register now
> http://p.sf.net/sfu/rsa-sfdev2dev1
> _______________________________________________
> Scikit-learn-general mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
>
>



-- 
Peter Prettenhofer

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Scikit-learn-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general

Reply via email to