I have just submitted a PR to brian's branch :) On 4 November 2011 11:13, Peter Prettenhofer <[email protected]> wrote: > Gilles, > > I was not aware of your work in _tree.pyx. Looks great! Still, I > didn't touch any line in `find_best_split` so the merging/rebase > should be quite straight-forward (though not fast-forward). @Gilles: > it would be great if you could submit a PR to Brians enh/ensemble > branch. > > thanks, > Peter > > 2011/11/4 Brian Holt <[email protected]>: >>>I have myself made a lot of changes in tree.py and _tree.pyx in a lot >> of places in the code. Wouldn't it be easier for you to merge your >> code into my files? As I see in [1, 2] your changes are localized, and >> hence it would be quicker for you to merge them into my files than for >> me merging all my changes. But I don't mind, I can also do the other >> way around. >> >> I agree Gilles about Peter's changes being localised, but I also agree with >> Peter that this discussion is best done on github. How about you submit a >> PR Gilles? >> >> >> ------------------------------------------------------------------------------ >> RSA(R) Conference 2012 >> Save $700 by Nov 18 >> Register now >> http://p.sf.net/sfu/rsa-sfdev2dev1 >> _______________________________________________ >> Scikit-learn-general mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general >> >> > > > > -- > Peter Prettenhofer > > ------------------------------------------------------------------------------ > RSA(R) Conference 2012 > Save $700 by Nov 18 > Register now > http://p.sf.net/sfu/rsa-sfdev2dev1 > _______________________________________________ > Scikit-learn-general mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/scikit-learn-general >
------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
