The difficulty in testing arpack is not because it's backported: On the
contrary, I wrote a full test suite for it [1]. It's not been merged
because ARPACK is particularly unstable across platforms, and folks thought
that having no tests was better than having test failures on some systems.
It's not a problem with testing backports per se.
Jake
[1] https://github.com/scikit-learn/scikit-learn/pull/984
On Thu, May 2, 2013 at 7:17 AM, Andreas Mueller <[email protected]>wrote:
> On 05/02/2013 03:14 PM, Lars Buitinck wrote:
> > 2013/5/2 Jacob Vanderplas <[email protected]>:
> >> Take a look at sklearn/utils/arpack.py. This is a backport of the scipy
> >> arpack: the file is basically copied literally, and then a hook at the
> >> bottom that replaces the main functions with the scipy version, if
> they're
> >> available.
> > Mind you, testing is harder when the external version is used
> conditionally.
> >
> We don't test arpack, though ;) It is really tough to test.
> For the MST code, maybe we can add some simple unit tests that work in
> both cases?
> +1 for just copying...
>
>
> ------------------------------------------------------------------------------
> Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
> Get 100% visibility into your production application - at no cost.
> Code-level diagnostics for performance bottlenecks with <2% overhead
> Download for free and get started troubleshooting in minutes.
> http://p.sf.net/sfu/appdyn_d2d_ap1
> _______________________________________________
> Scikit-learn-general mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
>
------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
Scikit-learn-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
