Hi all,

I'm working on updating py-earth for some recent changes in scikit-learn
and cython.  It seems like check_estimator has been significantly improved,
and I'm working through making py-earth compliant with it.  I've hit the
following issue, though.  It seems check_estimator tests score_samples
using only X as an argument, and py-earth's score_samples requires y as
well.  So, my question is: must score_samples work with just X (and
therefore maybe I should just remove it from py-earth) or is it okay to
have a score_samples that requires y, and I should try to find a workaround
for check_estimator?

Best,

Jason
_______________________________________________
scikit-learn mailing list
scikit-learn@python.org
https://mail.python.org/mailman/listinfo/scikit-learn

Reply via email to