Thanks, Joel. From your response I assume that the use of a y argument to score_samples is not a violation of the sklearn API, so I'll keep the method and find a workaround for the check_estimator test as it's currently written. I'll comment on the issue as well.
On Mon, Dec 10, 2018 at 2:58 PM Joel Nothman <joel.noth...@gmail.com> wrote: > We're trying to make check_estimator more flexible ( > https://github.com/scikit-learn/scikit-learn/pull/8022) but this is > certainly not something we had considered yet. Perhaps suggest it there? > > Or for now we could just make the check pass if score_samples yields a > TypeError with only X... > _______________________________________________ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn >
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
