Philippe Lhoste:
> So I removed this code and I send my latest versions of LexCPP, LexLua,
> LexPOV and LexVB, along with their properties file (just in case; some
> keyword changes mostly).
There are 50 changes in here. If I were to make 50 changes to a
piece of code then there would probably be several bugs so I don't
think it is a good idea to merge this just before a release. Possibly
the most important simple modifications could be included (adding
repeat .. until folding).
> PS.: I also changed some "const int param" to "int param" in functions
> definition parameters. Since these are not references, it doesn't seem
> useful to declare them as const. Even if param is changed, it is only a
> local change... But I can be wrong, of course.
I don't feel either way is greatly better. Using const allows some
more checking and sometimes makes it easier to reason about code,
which I like sometimes with variables that are about to be used in
some complex flow of control although that isn't the case with
parameters. I haven't modified these previously as code churn creates
bugs.
Neil
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest
