Neil Hodgson wrote:
So I removed this code and I send my latest versions of LexCPP, LexLua,
LexPOV and LexVB, along with their properties file (just in case; some
keyword changes mostly).
There are 50 changes in here.
So much? Wow! I didn't realised...
If I were to make 50 changes to a
piece of code then there would probably be several bugs so I don't
think it is a good idea to merge this just before a release.
Well, I am not in a hurry, these changes were in my code for quite some
time, so I suppose they can wait another version. And now, they are
available for everybody to test...
I would like to say they are fairly tested, since I use SciTE daily with
this code, but as I had to make some changes to remove unused code, I
can't say that anymore, and indeed I had to squash some bugs found
before sending...
Possibly
the most important simple modifications could be included (adding
repeat .. until folding).
That would be nice, somebody asked for it in the Lua list.
PS.: I also changed some "const int param" to "int param" in functions
definition parameters. Since these are not references, it doesn't seem
useful to declare them as const. Even if param is changed, it is only a
local change... But I can be wrong, of course.
I don't feel either way is greatly better. Using const allows some
more checking and sometimes makes it easier to reason about code,
which I like sometimes with variables that are about to be used in
some complex flow of control although that isn't the case with
parameters. I haven't modified these previously as code churn creates
bugs.
Well, in the above case, that's not complex flow, just two to five
lines, but I don't mind either way. The only thing annoying me is that
there is no real consistency from one lexer to the next, but I suppose
that's the drawback of open source...
--
Philippe Lhoste
-- (near) Paris -- France
-- http://Phi.Lho.free.fr
-- -- -- -- -- -- -- -- -- -- -- -- -- --
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest
