Neil Hodgson wrote:
Robert Roessler:

I seems to me that its [int] member function GetRelative() does a
styler.SafeGetCharAt() without using the [now infamous]
static_cast<unsigned char>()... is this an oversight that should be
corrected, or am I missing something here?

   Its an oversight. The SafeGetCharAt called within MatchIgnoreCase
could also receive a cast.

All right - I have finished converting my LexCaml.cxx to use StyleContext - as much as possible.

While overall it does make things simpler, the coloring and state management model is slightly *too* simple for my needs; in particular, I sometimes need to color "one more" char (like when recognizing the end of a quoted string or "(* ... *)" delimited comment) - at other times, the convention of coloring to currentPos-1 is fine.

Exposing a "ColourTo()" member function would obviate the need to use the original Accessor-based styler at all (for normal styling needs) - if this would be desirable. Of course, there is also the possibility of querying the main properties DB - which also goes through the old styler.

I have edited a version of StyleContext.h with the above-mentioned two changes implemented. It is at the usual place:

http://www.rftp.com/StyleContext.h

I will, of course, check it in if you would like - but your intentions in this regard were not explicit... :)

Robert Roessler
[EMAIL PROTECTED]
http://www.rftp.com
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest

Reply via email to