Neil Hodgson wrote:
The cancelFlag is used in both the UI thread and the execution
thread so should be protected. That is why InterlockedExchange is used
in the current code. The same effect should be possible by using the
JobQueue mutex in an int SetCancelFlag(int value) method.
The IDM_FINISHEDEXECUTE and IDM_JOBS cases are too complex to
contain within SciTEWin::Command so should be moved out into methods.
Thank you for the suggestions. I will implement them over the next week
or so. and upload a new version.
Including multiple changes in a patch makes it much harder to review.
I've uploaded a separate patch but my next release will obviously
contain it still as the two changes have common files. I hope this is
acceptable.
April
--
Babies are a good way to start people.
_______________________________________________
Scite-interest mailing list
Scite-interest@lyra.org
http://mailman.lyra.org/mailman/listinfo/scite-interest
