Validation of scm url fails because of ambiquities between source code and site
documentation
---------------------------------------------------------------------------------------------
Key: SCM-106
URL: http://jira.codehaus.org/browse/SCM-106
Project: Maven SCM
Type: Bug
Components: maven-scm-api
Reporter: Dennis Lundberg
I am trying out Continuum and am tracking down the cause of why I get an error
regarding the scm url that I provide when adding an ant project. This has led
me here. I copied the scm url from my maven 1 project.xml and got a very breif
error message telling me to enter a valid scm url.
My scm url looks like this:
scm|cvs|pserver|[EMAIL PROTECTED]|C:/Program/cvsnt/repositories|project-name
This works just fine using maven 1.
These two files are involved in this:
maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
maven-scm-site/src/site/apt/cvs.apt
AbstractScmManager.java has the following error message declared:
private final static String ILLEGAL_SCM_URL = "The scm url must be on the
form "
+ "'scm:<scm
provider><delimiter><provider specific part>' "
+ "where <delimiter> can be
either ':' or '|'.";
which explains how a correct scm url should look.
cvs.apt on the other hand does not have this explanation. It does say:
For all URLs below, we use a colon (:) as separator. If you use a colon for one
of the variables (e.g. a windows path), then use a pipe (|) as separator.
Then follows a bunch of examples, none of which use pipe (|) as a separator.
So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven
scm flags my scm url as invalid, but the docs for the urls are not really clear
about what a delimiter/separator is and where they are in the scm url.
Asuming that the source code is correct, the the docs need updating to reflect
this. There should also be an example using pipe as a separator. If someone can
confirm this I can write a patch for the docs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
