PerforceChangeLogConsumer should use relative paths
---------------------------------------------------

         Key: SCM-168
         URL: http://jira.codehaus.org/browse/SCM-168
     Project: Maven SCM
        Type: Bug

  Components: maven-scm-provider-perforce  
    Versions: 1.0-beta-3    
    Reporter: John Didion
    Priority: Critical
 Attachments: PerforceChangeLogConsumer.diff

It seems like all scm providers are dealing with relative paths, rather than 
absolute repository paths. PerforceCheckOutCommand is definitely doing this.  
PerforceChangeLogConsumer, however, does not, which means 
ChangeSet.containsFilename always returns false because it's comparing a 
relative path to an absolute one.

There are two changes. First, in PerforceChangeLogCommand:

{noformat}
PerforceChangeLogConsumer consumer = new PerforceChangeLogConsumer( 
((PerforceScmProviderRepository) repo).getPath(), startDate, endDate );
{noformat}

The attached diff is for the second set of changes, which are to 
PerforceChangeLogConsumer.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to